[struct_json] is compatible with msvc versions #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
qicosmos
reviewed
Oct 10, 2024
|
Code Coverage Report |
- Merged conditional checks for C++20 support and MSVC version. - Reduced redundancy by combining similar code paths. - Used a unified approach to handle both C++20 compliant compilers and fallback for older MSVC versions. - Ensured that the implementation uses fold expressions and generic lambdas when available, and falls back to visit_members_impl for older environments.
|
Code Coverage Report |
This reverts commit 2538348.
|
Code Coverage Report |
|
Code Coverage Report |
|
Code Coverage Report |
|
Code Coverage Report |
|
|
|
|
Code Coverage Report |
|
Code Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to ensure compatibility with different versions of the Microsoft Visual Studio (MSVC) compiler. The
_MSC_VERmacro is used to determine the compiler version, allowing the code to handle differences between Visual Studio 2019 (MSVC 14.2x) and Visual Studio 2022 (MSVC 14.30+). This is particularly important because VS2022 introduces full support for C++20 features, while earlier versions require a fallback implementation.What is changing
The code now includes conditional checks for
_MSC_VER:_MSC_VER >= 1930(Visual Studio 2022 or newer), the code leverages C++20 features such as generic lambdas and fold expressions._MSC_VER >= 1920 && _MSC_VER < 1930), the code falls back to an alternative implementation to maintain compatibility.This ensures that the code can be compiled with both VS2019 and VS2022 while taking full advantage of C++20 features where available.
Example
For example, the following macro-based logic ensures that the code behaves correctly in both compilers: